[202x] Propose adding vk::SampledTexture* types #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposal adds a set of `vk::SampledTexture*` types to represent SPIR-V's sampled image types. The intent is to replace and deprecate the `[[vk::combinedImageSampler]]` annotation. I have created this with the extension template with the intent of using the fast-track process, as this is a platform-specific feature that is already supported by all Vulkan hardware and drivers, and it does not change any existing language behavior.
s-perron
reviewed
Oct 17, 2024
There was a problem hiding this comment.
This generally look good to me. The only other detail is to consider how this will be implemented in clang. We might need a new attribute for the resource handle. See llvm/wg-hlsl#76.
s-perron
approved these changes
Nov 4, 2024
llvm-beanz
reviewed
Nov 4, 2024
proposals/NNNN-vk-sampled-texture.md
Outdated
| * Author(s): [Cassandra Beckley](https://github.com/cassiebeckley) | ||
| * Sponsor: [Steven Perron](https://github.com/s-perron) and TBD | ||
| * Status: **Under Consideration** | ||
| * Required Version: HLSL 202x |
There was a problem hiding this comment.
Per our discussion:
Marking the attribute that you want to remove deprecated in HLSL 2021, then remove it in HLSL 202x seems like a good path forward.
For the new types, we can use a __has_feature check in the preprocessor and make it available in all language modes.
s-perron
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal adds a set of
vk::SampledTexture*types to represent SPIR-V's sampled image types. The intent is to replace and deprecate the[[vk::combinedImageSampler]]annotation.I have created this with the extension template with the intent of using the fast-track process, as this is a platform-specific feature that is already supported by all Vulkan hardware and drivers, and it does not change any existing language behavior.