-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLflow improvements for metric performance - batching #23
base: master
Are you sure you want to change the base?
MLflow improvements for metric performance - batching #23
Conversation
Signed-off-by: Walter Martin <wamartin@microsoft.com>
@noise-field, @sgugger, I think you two are the best set up to review this PR |
Signed-off-by: Walter Martin <wamartin@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me, though I'm not an expert in MlFlow.
If the change helps, it would be great to upstream it into the main Transformers repo! :-)
that's the plan :) |
Signed-off-by: Walter Martin <wamartin@microsoft.com>
Signed-off-by: Walter Martin <wamartin@microsoft.com>
Signed-off-by: Walter Martin <wamartin@microsoft.com>
@jingyanwangms or @harshithapv could I get a review? |
@wamartin-aml this change looks good but if you plan to upstream to transformers repo, I would suggest you make the PR there. We sync with transformers master periodically. So your change will be taken from there anyways. |
Ok, will do! |
Signed-off-by: Walter Martin wamartin@microsoft.com
What does this PR do?
This PR simplifies which integrations are needed in the case of both AzureML and MLflow being available and it batches metric logging for improved performance.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.