Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and import SKL Feature Pre-processing: OneHotEncoder #136

Closed
ksaur opened this issue Jun 13, 2020 · 2 comments · Fixed by #193
Closed

Cleanup and import SKL Feature Pre-processing: OneHotEncoder #136

ksaur opened this issue Jun 13, 2020 · 2 comments · Fixed by #193
Assignees
Labels
good first issue Good for newcomers

Comments

@ksaur
Copy link
Contributor

ksaur commented Jun 13, 2020

We have the original draft of the OneHotEncoder code uploaded in this branch. All credit here goes to @scnakandala, the original author and brains behind this.

It contains an un-edited implementation of OneHotEncoder here.

There is a single test file here that needs to be cleaned up and passing.

Notes:

  • We had to treat strings a bit differently because of the way they are represented in tensors
    • We should add more robust tests here
  • the retain_order flag in OneHotEncoder is not yet implemented. We can wait on that for later unless someone gets inspired.
@ksaur ksaur added the good first issue Good for newcomers label Jun 13, 2020
@TuanNguyen27
Copy link
Contributor

hey @ksaur can i also work on this ? :)

@ksaur
Copy link
Contributor Author

ksaur commented Jun 16, 2020

I did one small commit to the branch, just adding a flag that might be confusing and cause the code to not work; let me know if you run into issues or have questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants