-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one hot encoder #193
Merged
Merged
one hot encoder #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is incase helpful!
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 93.72% 93.79% +0.06%
==========================================
Files 28 30 +2
Lines 1609 1772 +163
Branches 284 314 +30
==========================================
+ Hits 1508 1662 +154
Misses 58 58
- Partials 43 52 +9
Continue to review full report at Codecov.
|
interesaaat
reviewed
Jul 15, 2020
Ok I added few comments. Will merge once all checks pass |
Closes #136. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-learn one-hot-encoder impl
Scikit learn had API change that removed categorical_features, complicating things a bit