Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one hot encoder #193

Merged
merged 72 commits into from
Jul 15, 2020
Merged

one hot encoder #193

merged 72 commits into from
Jul 15, 2020

Conversation

ksaur
Copy link
Contributor

@ksaur ksaur commented Jul 14, 2020

scikit-learn one-hot-encoder impl
Scikit learn had API change that removed categorical_features, complicating things a bit

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #193 into master will increase coverage by 0.06%.
The diff coverage is 95.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   93.72%   93.79%   +0.06%     
==========================================
  Files          28       30       +2     
  Lines        1609     1772     +163     
  Branches      284      314      +30     
==========================================
+ Hits         1508     1662     +154     
  Misses         58       58              
- Partials       43       52       +9     
Flag Coverage Δ
#unittests 93.79% <95.02%> (+0.06%) ⬆️
Impacted Files Coverage Δ
hummingbird/ml/operator_converters/skl_iforest.py 90.21% <90.21%> (ø)
hummingbird/ml/_container.py 96.72% <100.00%> (+0.56%) ⬆️
hummingbird/ml/_topology.py 90.90% <100.00%> (+0.34%) ⬆️
hummingbird/ml/operator_converters/__init__.py 100.00% <100.00%> (ø)
...mmingbird/ml/operator_converters/_base_operator.py 100.00% <100.00%> (ø)
...rd/ml/operator_converters/_tree_implementations.py 98.08% <100.00%> (+0.05%) ⬆️
hummingbird/ml/operator_converters/constants.py 100.00% <100.00%> (ø)
...bird/ml/operator_converters/skl_one_hot_encoder.py 100.00% <100.00%> (ø)
hummingbird/ml/supported.py 88.70% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1922480...913bd95. Read the comment docs.

@ksaur ksaur linked an issue Jul 14, 2020 that may be closed by this pull request
@ksaur ksaur requested a review from interesaaat July 15, 2020 00:00
@interesaaat
Copy link
Collaborator

Ok I added few comments. Will merge once all checks pass

@interesaaat
Copy link
Collaborator

Closes #136.

@interesaaat interesaaat merged commit e50eb9c into master Jul 15, 2020
@interesaaat interesaaat deleted the ksaur/ohe branch July 15, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup and import SKL Feature Pre-processing: OneHotEncoder
5 participants