Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick PDB Symbols publishing change into maint/maint-67 branch #42

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Cherry-pick PDB Symbols publishing change into maint/maint-67 branch #42

merged 1 commit into from
Nov 2, 2020

Conversation

jefgen
Copy link
Member

@jefgen jefgen commented Nov 2, 2020 •
edited
Loading

Summary

Note: This is a cherry-pick into the maint/maint-67 branch from PR #41.

This updates the PDB symbols publishing to use the public server instead of the internal one.
(Thanks to @huichen123 for noticing this. We were actually publishing to the Microsoft internal server for symbols instead of the public one.)

PR Checklist

  • I have verified that my change is specific to this fork and cannot be made upstream.
  • I am making a maintenance related change.
  • I am making a change that is related to usage internal to Microsoft.
  • I am making a change that is related to the Windows OS build of ICU.
  • CLA signed. If not, please see here to sign the CLA.

@jefgen
Cherry-pick PDB Symbols publishing change to maint/maint-67 branch
b847820 
Original message:
Update symbols publishing to use the public server instead of the internal one. (#41)

(cherry picked from commit c7ca8ec)
@jefgen jefgen requested review from huichen123, daniel-ju and a team November 2, 2020 20:12
@jefgen jefgen merged commit 390cb62 into maint/maint-67 Nov 2, 2020
@jefgen jefgen deleted the user/jefgen/update-maint67-symbols branch November 2, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-ju daniel-ju daniel-ju approved these changes

@axelandrejs axelandrejs axelandrejs approved these changes

@huichen123 huichen123 Awaiting requested review from huichen123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jefgen @axelandrejs @daniel-ju