Update French locales to use U+202F instead of U+00A0 for the number grouping separator #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-ju
force-pushed
the
user/daju/remove-fr-202F-space-override
branch
from
a388493
to
0ce8be1
Compare
jefgen
approved these changes
Mar 12, 2021
icu-patches/patches/002-MSFT-Patch-ICU_test_changes_for_MSFT_changes.patch
Show resolved
Hide resolved
icu-patches/patches/002-MSFT-Patch-ICU_test_changes_for_MSFT_changes.patch
Show resolved
Hide resolved
jefgen
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change updates French locales to use U+202F (NARROW NON BREAKING SPACE) instead of U+00A0 (NON BREAKING SPACE) for the number grouping separator, aligning with upstream CLDR.
The ICU tests and patch files were updated accordingly for this change, with all tests passing now.
PR Checklist
Detailed Description
CLDR 34 switched the number grouping separator for fr-* locales from U+00A0 (NON BREAKING SPACE) to U+202F (NARROW NON BREAKING SPACE). However, we applied overrides and patches internally to revert this change at the time.
We have decided that since this change may get adopted more broadly in other locales, we should take the change to align with CLDR now (Upstream CLDR ticket: CLDR-11423).
This change updates the ICU data file (
fr.txt) and modifies the ICU tests to remove our patches now that we're aligned with upstream CLDR/ICU for this data for all French locales. However, the fr-CA locale still uses the U+00A0 character upstream, which is intentionally left as-is here to have parity with CLDR. If the fr-CA data is changed upstream to match other fr-* locales, then we'll pull in that change in a future release.