Add extra locales to MS-ICU from CLDR-MS from NLS "MS-Only" culture data #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds additional/extra locales to MS-ICU from CLDR-MS.
PR Checklist
Detailed Description
This change rebuilds the MS-ICU data using CLDR-MS in order to add additional/extra locales from the updated CLDR-MS data.
These extra locales were the "MS-Only" locales from the NLS
culture.xml
data, which were ported to CLDR-MS.I wrote a tool to dump out the list of MS-ICU and NLS locales, and then used the output to create a diff of the two sets of locales.
I uploaded an annotated diff of the locale lists here:
https://gist.github.com/jefgen/fee0eb88560f55993b90de72a3e250e9
Comparing the sets of locales, there were only 13 missing locales in MS-ICU compared to NLS.
The NLS specific locales that were missing (and which this change adds) are listed below:
This change adds the missing locales to MS-ICU, meaning that all of the locales in NLS will now be present in MS-ICU as well (though they might have slightly different names though), which will address issue #64 about missing locales.
This change also adds additional aliases to MS-ICU as well in order to help with naming differences compared to the NLS locale names.
Since these locales had limited data, I had to patch the ICU tests to skip various tests for them, similar to some of the existing CLDR Seed locales. I added a new MSFT-Patch file for these changes.
The extra locale data also apparently pushed us just over the limit in
icu/icu4c/source/tools/toolutil/package.h
for the fixed-sizeSTRING_STORE_SIZE
buffer. I had to increase the size in order to get the data to build. I added another new MSFT-Patch file for this change as well.