Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suggestion appears and hangs after enter #236

Merged
merged 2 commits into from
Apr 14, 2024
Merged

fix: suggestion appears and hangs after enter #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcfc3e6
fix: suggestion appears and hangs after enter
cpendery Apr 14, 2024
6df7161
Merge branch 'main' into fix/suggestion-hang-post
cpendery Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ui/suggestionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ export class SuggestionManager {

update(keyPress: KeyPress): boolean {
const { name, shift, ctrl } = keyPress;
if (name == "return") {
this.#term.clearCommand(); // clear the current command on enter
}
if (!this.#suggestBlob) {
return false;
}
Expand All @@ -186,9 +189,6 @@ export class SuggestionManager {
}
this.#term.write(removals + chars);
} else {
if (name == "return") {
this.#term.clearCommand(); // clear the current command on enter
}
return false;
}
log.debug({ msg: "handled keypress", ...keyPress });
Expand Down
Loading