Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"copy value" from variables debugger window not working #290

Closed
wants to merge 1 commit into from

Conversation

drungrin
Copy link
Contributor

@msftclas
Copy link

msftclas commented Aug 20, 2019

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The solution works well, except we need handle array/collection/map better.

referenceId = context.getRecyclableIdPool().addObject(containerNode.getThreadId(), varProxy);
evaluateName = varProxy.getEvaluateName();
Copy link
Contributor

@testforstephen testforstephen Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Collection and Map type, we did special handling to show their logical structure, so their display style looks like array.
image

Currently when you hover on 0: HashMap$Node@64, and click Copy Value, the generated evaluateName is map.0. Evaluate engine will report Cannot evaluate because of compilation error(s): Syntax error on token ".0", delete this token..

There are two solutions in my mind.

  1. The first solution is to generate the correct evaluate name. That means we need handle the evaluate name specially for the type java.util.Map, java.util.Collection, java.util.Map$Entry.
  • If the container is java.util.Map, the evaluate name for the children is like map.entrySet().toArray()[0].
  • If the container is java.util.Map$Entry, the evaluate name for the children is like map.entrySet().toArray(new java.util.Map.Entry[0])[0].getKey().

The cons is the problem will become complex when the hierarchy is deep.

  1. The second solution is to disable Copy Value on the children of Map and Collection, only enable it on the Map and Collection itself, and return their toString value.
    For example, when hover on map, the copy operation should return {a=1}.

Similarly, when copy an array, we need return its toString() instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first solution, when the hiearchy is deep, the evaluateName is already complex, in my opinion this isn't an issue.

I really dont like the second solution.

So, if you agree, I'll implement the solution 1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In solution 1, it may be a little tricky for generating the correct evaluate expression for Collection type. For example, in order to copy the nth element's children, the evaluate expression is like collection.toArray()[n].x, this will report compilation error because of java type check.

@testforstephen
Copy link
Contributor

@drungrin thanks for the initial PR, close it with another PR #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"copy value" from variables debugger window not working
3 participants