-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"copy value" from variables debugger window not working #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. The solution works well, except we need handle array/collection/map better.
referenceId = context.getRecyclableIdPool().addObject(containerNode.getThreadId(), varProxy); | ||
evaluateName = varProxy.getEvaluateName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Collection and Map type, we did special handling to show their logical structure, so their display style looks like array.
Currently when you hover on 0: HashMap$Node@64
, and click Copy Value
, the generated evaluateName is map.0
. Evaluate engine will report Cannot evaluate because of compilation error(s): Syntax error on token ".0", delete this token.
.
There are two solutions in my mind.
- The first solution is to generate the correct evaluate name. That means we need handle the evaluate name specially for the type
java.util.Map
,java.util.Collection
,java.util.Map$Entry
.
- If the container is
java.util.Map
, the evaluate name for the children is likemap.entrySet().toArray()[0]
. - If the container is
java.util.Map$Entry
, the evaluate name for the children is likemap.entrySet().toArray(new java.util.Map.Entry[0])[0].getKey()
.
The cons is the problem will become complex when the hierarchy is deep.
- The second solution is to disable
Copy Value
on the children of Map and Collection, only enable it on the Map and Collection itself, and return their toString value.
For example, when hover onmap
, the copy operation should return{a=1}
.
Similarly, when copy an array, we need return its toString() instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the first solution, when the hiearchy is deep, the evaluateName is already complex, in my opinion this isn't an issue.
I really dont like the second solution.
So, if you agree, I'll implement the solution 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In solution 1, it may be a little tricky for generating the correct evaluate expression for Collection
type. For example, in order to copy the nth element's children, the evaluate expression is like collection.toArray()[n].x
, this will report compilation error because of java type check.
Fixes microsoft/vscode-java-debug#624