Fix perf issue on get locations of breakpoint #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
approved these changes
Oct 24, 2017
ansyral
reviewed
Oct 24, 2017
| List<Location> newLocations = collectLocations(refType, lineNumber); | ||
| if (!newLocations.isEmpty()) { | ||
| locations.addAll(newLocations); | ||
| } else if (includeNestedTypes) { |
There was a problem hiding this comment.
what's the advice?
There was a problem hiding this comment.
i mean why here it is else if rather than if?
There was a problem hiding this comment.
if the breakpoint located in the refType, no need to search the nested type.
yaohaizh
approved these changes
Oct 24, 2017
|
Hello, @testforstephen, how do you know that ReferenceType.nestedTypes invokes VirtualMachine.allClasses? |
|
@Goom11 Please reference JDT JDI implementation. https://github.com/eclipse/eclipse.jdt.debug/blob/master/org.eclipse.jdt.debug/jdi/org/eclipse/jdi/internal/ReferenceTypeImpl.java#L1241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
fix bug #49.
Nested types are just needed for those already loaded classes. For the referenceType from ClassPrepareEvent, no need to search the locations in the nested types. For newly loaded classes, the debugger has also registered ClassPrepareRequest for their local types, so the debugger will handle the local types in ClassPrepareEvent handler.