Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename embedding cache files #914

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Rename embedding cache files #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions service/Core/Handlers/GenerateEmbeddingsHandlerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,23 @@ protected static string GetEmbeddingProviderName(object generator)

protected static string GetEmbeddingGeneratorName(object generator)
{
// TODO: use the model name
return "TODO";
/* @todo Embedding cache
*
* The orchestrator is caching embeddings, and the cache key would be composed by:
*
* 1. the generator class name (see GetEmbeddingProviderName)
* 2. the model used
*
* Embedding generators do not expose the model in use though, so we're using a
* temporary placeholder.
*
* Work to do: remove embedding cache from the pipeline and leave it to embedding
* generators to cache (dev branch: embeddingcache), so that all clients and handlers
* will benefit. This approach removes also the need for generators to expose
* internal details.
*/

return "__";
}

protected class PartitionInfo(
Expand Down