Helper for parsing enums from string #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
reviewed
Jun 28, 2024
andrueastman
reviewed
Jul 3, 2024
There was a problem hiding this comment.
This looks good to me.
@MartinM85 Any chance you were looking to update microsoft/kiota-http-dotnet#266 with a local reference of this PR first to validate the changes here before we merge?
Confirmed...with a local reference of Kiota.Abstractions and enum helper called from SendPrimitiveAsync, the tests added in microsoft/kiota-http-dotnet#266 passed |
andrueastman
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good from my end. Will merge once @baywet does a final review.
baywet
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #258
Generic method is same as the current method implemented in https://github.com/microsoft/kiota-serialization-json-dotnet/blob/d0454daecb7ec2327f3e55d642fa510cf617e8b5/src/JsonParseNode.cs#L214