Merge remote-tracking branch 'upstream/main' into fix-adhere-to-otel-…

…span
microsoft · Dec 13, 2024 · 3c48333 · 3c48333
2 parents 7f78df4 + d695eb6
commit 3c48333
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -19,6 +19,7 @@ on:
     branches: [ main ]
   schedule:
     - cron: '40 16 * * 3'
+  workflow_dispatch:
 
 jobs:
   analyze:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,15 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [1.4.6] - 2024-10-12
+## [1.4.7] - 2024-12-13
 
 ### Changed
 
 - Updated HTTP span attributes to comply with updated OpenTelemetry semantic conventions. [#182](https://github.com/microsoft/kiota-http-go/issues/182)
 
+## [1.4.6] - 2024-12-13
+
+### Changed
+
+- Fixed a bug where headers inspection handler would fail upon receiving an error.
+
 ## [1.4.5] - 2024-09-03
 
 ### Changed
+
 - Fixed a bug in compression middleware which caused empty body to send on retries
 
 ## [1.4.4] - 2024-08-13

diff --git a/headers_inspection_handler.go b/headers_inspection_handler.go
@@ -104,6 +104,9 @@ func (middleware HeadersInspectionHandler) Intercept(pipeline Pipeline, middlewa
 		}
 	}
 	response, err := pipeline.Next(req, middlewareIndex)
+	if err != nil {
+		return response, err
+	}
 	if reqOption.GetInspectResponseHeaders() {
 		for k, v := range response.Header {
 			if len(v) == 1 {
@@ -113,8 +116,5 @@ func (middleware HeadersInspectionHandler) Intercept(pipeline Pipeline, middlewa
 			}
 		}
 	}
-	if err != nil {
-		return response, err
-	}
 	return response, err
 }