Ensure get_parse_node does not fail when response body is empty #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louim
requested review from
andrueastman,
baywet,
zengin,
MIchaelMainer,
peombwa,
calebkiage,
Ndiritu and
rkodev
as code owners
There was a problem hiding this comment.
Thanks again @louim
Any chance you can
- bump the patch version https://github.com/microsoft/kiota-http-ruby/blob/main/lib%2Fmicrosoft_kiota_faraday%2Fversion.rb
- add an entry in the changelog
Similar to #27 before we merge this?
baywet
requested changes
Feb 16, 2024
|
Done! Would it be possible to approve to to run the Ruby workflows? My workflow runs needs admin approval |
louim
force-pushed
the
bugfix/nil-empty-content-body
branch
from
ddc2915
to
5b1bd32
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against empty response body causing an error when finding the parse node.
I added some specs.
closes #26