Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Java 8 ]: Replace isBlank with Compatibility.isBlank() #1089

Merged
merged 2 commits into from
Feb 21, 2024
Merged

[ Java 8 ]: Replace isBlank with Compatibility.isBlank() #1089

merged 2 commits into from
Feb 21, 2024

Conversation

sm3136
Copy link

@sm3136 sm3136 commented Feb 21, 2024

Recently ran into an issue at my work with compatibility to Java 8 being broken in msgraph-sdk-java due to this kiota-java dependency.

closes microsoftgraph/msgraph-sdk-java#1831

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
Can you also please:

  • bump the patch version in gradle.properties
  • add a changelog entry (today's date, changed section)
  • update the versions in README.md

This will help make sure this PR gets published fast.

@sm3136 sm3136 requested a review from baywet February 21, 2024 15:43
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge February 21, 2024 15:46
@baywet baywet merged commit 0c0514d into microsoft:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java 8 question
2 participants