Fix UnsupportedOperationException when not providing scopes to AzureIdentityAccessTokenProvider #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentityAccessTokenProvider Fixes microsoftgraph/msgraph-sdk-java#1882
joakibj
requested review from
baywet,
MIchaelMainer,
zengin,
ramsessanchez,
andrueastman and
Ndiritu
as code owners
|
@microsoft-github-policy-service agree |
andrueastman
previously approved these changes
Mar 20, 2024
baywet
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks for the contribution.
Can you:
- update l132 to 135 to work on a new array instead of the field, so the implementation is identical to the dotnet one
- bump the patch version (today's date) in the changelog so we can promptly release those changes.
- update the version accordingly in gradle.properties and in the user agent options
This comment was marked as outdated.
This comment was marked as outdated.
|
update: I've done the changelog changes, only the other points are left |
|
Conflicts have been resolved. A maintainer will take a look shortly. |
…et implementation with regard to internal handling of scopes * Updated to version 1.1.1 in gradle.properties * Updated to version 1.1.1 in UserAgentHandlerOption * Fixed junit assert usage. API is expected, actual. Not actual, expected
|
Please see my latest update
There is also a difference from the dotnet implementation at line 66, as it seems dotnet does case insensitive ordering of the scopes. But I believe this is out of scope 😎 for this pull request / issue |
baywet
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoftgraph/msgraph-sdk-java#1882