-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MultipartBody filename directive #1150
Merged
andrueastman
merged 8 commits into
microsoft:main
from
piotrooo:feature/introduce-multipartbody-filename-directive
Apr 4, 2024
Merged
Introduce MultipartBody filename directive #1150
andrueastman
merged 8 commits into
microsoft:main
from
piotrooo:feature/introduce-multipartbody-filename-directive
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrooo
requested review from
baywet,
zengin,
ramsessanchez,
andrueastman and
Ndiritu
as code owners
April 2, 2024 16:04
andrueastman
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @piotrooo
Any chance you can
- Run
./gradlew spotlessApply
to fix the lint errors in the PR - Update the changelog in the repository root
Otherwise, this looks good to me.
andrueastman
reviewed
Apr 3, 2024
components/abstractions/src/main/java/com/microsoft/kiota/MultipartBody.java
Show resolved
Hide resolved
…tipartbody-filename-directive
auto-merge was automatically disabled
April 4, 2024 09:05
Head branch was pushed to by a user without write access
andrueastman
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1146