Ensure reading request body does not drain the input stream if stream is not resettable #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently override the Request body's
writeTo
method which was not resetting the input stream after the body is written e.g. by a logging interceptor. The network call would find an empty request body.This PR determines if the request body is resettable & configures
isOneShot()
to prevent non-resettable streams from being drained by logging middleware.closes microsoftgraph/msgraph-sdk-java#2037