Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve user errors instead of creating new ApiExceptions #742

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Preserve user errors instead of creating new ApiExceptions #742

merged 2 commits into from
Oct 13, 2023

Conversation

andreaTP
Copy link
Contributor

Bug found here: microsoft/kiota#3401 (comment)

There was too much to be done to test in this repo, I tested locally against the kiota integration tests.

@andreaTP andreaTP mentioned this pull request Oct 13, 2023
Merged
baywet
baywet approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@baywet baywet enabled auto-merge October 13, 2023 14:10
@baywet baywet merged commit 02e7f8e into microsoft:main Oct 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaTP @baywet