Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/form encoded #469

Merged
merged 9 commits into from
Dec 16, 2022
Merged

feature/form encoded #469

merged 9 commits into from
Dec 16, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Dec 15, 2022

@baywet
- fixes a bug where date only parsing would be inaccurate
1e8cbb2 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes nullable get child node declaration
c339cbe 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes a bug where false values would never get written
1dec1a2 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds form serialization package
d43f029 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Publish
2f82550 
 - @microsoft/kiota-abstractions@1.0.0-preview.10
 - @microsoft/kiota-authentication-azure@1.0.0-preview.8
 - @microsoft/kiota-authentication-spfx@1.0.0-preview.4
 - @microsoft/kiota-http-fetchlibrary@1.0.0-preview.11
 - @microsoft/kiota-serialization-form@1.0.0-preview.2
 - @microsoft/kiota-serialization-json@1.0.0-preview.11
 - @microsoft/kiota-serialization-text@1.0.0-preview.10
@baywet baywet self-assigned this Dec 15, 2022
@baywet baywet temporarily deployed to build_test December 15, 2022 20:43 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 15, 2022 20:43 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 15, 2022 20:43 — with GitHub Actions Inactive
@baywet
- fixes nullability information for parse node scalar values
b2fb964 
- fixes boolean parsing for text and form

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet temporarily deployed to build_test December 16, 2022 14:13 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 14:13 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 14:13 — with GitHub Actions Inactive
@baywet
- fixes key encoding for URI encoding serialization
e0ef4ea 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet temporarily deployed to build_test December 16, 2022 17:13 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 17:13 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 17:13 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 18:14 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 18:14 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 18:14 — with GitHub Actions Inactive
gavinbarron
gavinbarron requested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to make sure that we have all the tests getting run in the browser context, other that that this looks good to me

@baywet @gavinbarron
- adds additional unit tests to browser
05ce9cd 
Co-authored-by: Gavin Barron <gavin.barron@gmail.com>
@baywet baywet temporarily deployed to build_test December 16, 2022 19:25 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 19:25 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test December 16, 2022 19:25 — with GitHub Actions Inactive
gavinbarron
gavinbarron approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baywet baywet merged commit 1f8e02f into main Dec 16, 2022
@baywet baywet deleted the feature/form-encoded branch December 16, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@nikithauc nikithauc Awaiting requested review from nikithauc

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @gavinbarron