Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio Build Targets for OpenAPI Reference #1190

Merged
merged 27 commits into from
May 5, 2022
Merged

Visual Studio Build Targets for OpenAPI Reference #1190

merged 27 commits into from
May 5, 2022

Conversation

darrelmiller
Copy link
Member

@darrelmiller darrelmiller commented Feb 11, 2022 •
edited
Loading

This enables Visual Studio to do compile time design generation when using the dotnet openapi tool https://docs.microsoft.com/en-us/aspnet/core/web-api/Microsoft.dotnet-openapi?view=aspnetcore-6.0

Issues #544

Also includes some additional tests because my branch management skills are poor.

@baywet baywet linked an issue Feb 11, 2022 that may be closed by this pull request
Add support for dotnet OpenApiReference #544
Closed
baywet
baywet requested changes Feb 11, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the workflow needs to be updated to publish this package and do the code-sign + cred scan (compliance)

@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@baywet
Copy link
Member

baywet commented Mar 4, 2022

another aspect is taking a dependency onto kiota so it gets installed with that extension.
and another aspect is adding entries to this enum so the UI and the dotnet CLI can call this new extension. https://github.com/dotnet/aspnetcore/blob/main/src/Tools/Microsoft.dotnet-openapi/src/CodeGenerator.cs

@baywet
- adds missing unit test after merge
34c178d 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet linked an issue May 4, 2022 that may be closed by this pull request
Release kiota image on mcr.microsoft.com and dotnet tool on nuget.org #122
Closed
@baywet
Copy link
Member

baywet commented May 4, 2022 •
edited
Loading

TODO:

  • rename the targets package to fall under Microsoft.OpenAPI
  • rename the kiota package name to fall under Microsoft.OpenAPI
  • add ADO workflow for both packages (with credscan, code sign etc...)
  • add/update adequate workflow for mcr.microsoft.com image
  • changelog entry

@baywet baywet marked this pull request as draft May 4, 2022 19:18
@baywet baywet assigned baywet and unassigned darrelmiller May 4, 2022
@baywet
- renames reference package
c09c593 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet added 4 commits May 5, 2022 09:04
@baywet
- fixes policheck test path
f426384 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes tests path for credscan
9ecf3e5 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes pack commands
5488975 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- another attempt at fixing the pack comand
4cfab8c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Copy link
Member

baywet commented May 5, 2022

related https://github.com/microsoft/mcr/pull/1890

baywet added 10 commits May 5, 2022 11:15
@baywet
- switched to cli instead of broken tasks
3bc2aad 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- typo fix
39a58bc 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- switches to CLI for dotnet publish
7288c40 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- updates docker worfklow to push to MCR
a975454 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds changelog entry for public release
119935f 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes exe publication for kiota
f8da493 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- removes the dotnet text project that should have been removed durin…
d2cf6fd 
…g migration

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- updates public documentation after public release
9acf492 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- updates broken links in docker file
9d5f394 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- disables condition for deployment test
f8dc830 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Copy link
Member

baywet commented May 5, 2022

Note: we're still missing the AME steps, pending on @ddyett approval for my group membership (MCR onboarders)

@baywet baywet marked this pull request as ready for review May 5, 2022 18:21
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.6% 88.6% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 8dba4cf into main May 5, 2022
@baywet baywet deleted the dm/vsext branch May 5, 2022 18:29
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label May 5, 2022
This was referenced May 5, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees

@baywet baywet

Labels
generator Issues or improvements relater to generation capabilities.
Projects
None yet
Milestone
Complete Graph API Surface support
2 participants
@darrelmiller @baywet