Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Fixed a bug in Go generator where temporary url template parameters would not be used preventing the use of raw urls #1311

Merged
merged 3 commits into from
Mar 3, 2022
Merged

- Fixed a bug in Go generator where temporary url template parameters would not be used preventing the use of raw urls #1311

merged 3 commits into from
Mar 3, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Mar 1, 2022 •
edited
Loading

@baywet baywet added this to the Community Preview milestone Mar 1, 2022
@baywet baywet added the Go label Mar 1, 2022
@baywet baywet self-assigned this Mar 1, 2022
@baywet baywet enabled auto-merge March 1, 2022 19:10
@baywet baywet mentioned this pull request Mar 1, 2022
Closed
@baywet baywet disabled auto-merge March 2, 2022 02:06
andrueastman
andrueastman previously approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@baywet baywet force-pushed the bugfix/go-tpl-params branch from d87acb0 to 758f87b Compare March 2, 2022 12:39
andrueastman
andrueastman previously approved these changes Mar 2, 2022
View reviewed changes
@baywet baywet marked this pull request as draft March 2, 2022 12:48
@baywet baywet force-pushed the bugfix/go-tpl-params branch from 758f87b to 49c3f0e Compare March 2, 2022 17:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet
Copy link
Member Author

baywet commented Mar 2, 2022

update: I've pushed additional changes to pass the request information to the authentication provider and the request adapter by reference and not by value copy.
passing by value copy had unanticipated side effects that prevented using the request builders with raw urls (see example below)

here is a generation diff

The detailed analysis of the issue can be found here.

response, err := messages.NewMessagesRequestBuilder("https://graph.microsoft.com/v1.0/users/jane@contoso.com/messages", adapter).Get(nil)
// would fail with invalid scheme.

@baywet baywet marked this pull request as ready for review March 2, 2022 17:53
@baywet baywet requested a review from andrueastman March 2, 2022 17:54
@baywet baywet merged commit de55f78 into main Mar 3, 2022
@baywet baywet deleted the bugfix/go-tpl-params branch March 3, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees

@baywet baywet

Labels
Go
Projects
None yet
Milestone
Community Preview
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman