-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/discriminator support python #1500
Conversation
30cb74f
to
8fd37d4
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment on the parsable interface definition.
I also believe the generation code should be updated to implement the discriminator method generation.
abstractions/python/kiota/abstractions/serialization/parsable.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
|
…ontent-response-python
…-specific-content-types-python
…ure/field-deserializers-simplification-python
… feature/request-config-revamp
Feature/request config revamp
…implification-python Feature/field deserializers simplification python
…nt-types-python Add support for vendor specific content types
…ython Add support for no content responses
@samwelkanda thanks for the great stride here! linked the issues from the other PRs since they get closed only if the PR targets the main branch. I know serialization json is failing, I believe it's because it depends on changes made in abstractions that haven't been published yet. Ready to merge when you are. |
What this PR does?
This PR
Adds #1256 Python Discriminator Support in abstractions, http and serialization packages