Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/discriminator support python #1500

Merged
merged 50 commits into from
Jul 18, 2022

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Apr 7, 2022

What this PR does?

This PR
Adds #1256 Python Discriminator Support in abstractions, http and serialization packages

  • introduce a new ParsableFactory type in the abstractions serialization package
  • update parse node interface to take the new factory as parameter (getObjectValue, getCollectionOfObjectValues)
  • add factory to request adapter interface and implementation as parameter, and pass the factory to the parse node methods
  • bump abstractions, http and serialization packages

@samwelkanda samwelkanda self-assigned this Apr 14, 2022
@samwelkanda samwelkanda linked an issue Apr 14, 2022 that may be closed by this pull request
8 tasks
@samwelkanda samwelkanda force-pushed the feature/discriminator-support-python branch from 30cb74f to 8fd37d4 Compare April 14, 2022 14:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment on the parsable interface definition.
I also believe the generation code should be updated to implement the discriminator method generation.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@samwelkanda
Copy link
Contributor Author

Thanks for making the changes. I believe the http and json serialization manifests need to be updated to require the new version of abstractions, as well as the generation code.
@baywet Currently, package versions for the Kiota dependencies are not hardcoded, therefore on install it will fetch the latest version.

@samwelkanda samwelkanda requested a review from baywet July 14, 2022 17:13
baywet
baywet previously approved these changes Jul 14, 2022
@baywet
Copy link
Member

baywet commented Jul 15, 2022

@samwelkanda thanks for the great stride here! linked the issues from the other PRs since they get closed only if the PR targets the main branch. I know serialization json is failing, I believe it's because it depends on changes made in abstractions that haven't been published yet. Ready to merge when you are.

@samwelkanda samwelkanda merged commit 72f5e75 into main Jul 18, 2022
@samwelkanda samwelkanda deleted the feature/discriminator-support-python branch July 18, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants