Typescript Adding model interface, serializer and deserializer functions and remove model classes #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikithauc
requested review from
andrueastman,
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
ramsessanchez and
calebkiage
as code owners
nikithauc
changed the title
baywet
requested changes
May 10, 2022
baywet
previously approved these changes
Mar 29, 2023
3 tasks
baywet
requested changes
Apr 13, 2023
|
@andrueastman @rkodev would you mind giving it a look just for sanity please? |
baywet
previously approved these changes
Apr 14, 2023
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
src/Kiota.Builder/Writers/TypeScript/TypeScriptConventionService.cs
Outdated
Show resolved
Hide resolved
andrueastman
approved these changes
Apr 25, 2023
baywet
approved these changes
Apr 25, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1013
fixes #1521
fixes #1966
Generated samples : https://github.com/microsoft/kiota-typescript/tree/nikithauc/sample-interfaces/packages/test/generatedCode/models/microsoft/graph
Graph v1 generation : https://github.com/microsoftgraph/msgraph-sdk-typescript/tree/nikithauc/sample-interfaces/src