Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- changes with by by for indexers replacements #2564

Merged
merged 1 commit into from
Apr 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Kiota.Builder/Refiners/GoRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public override Task Refine(CodeNamespace generatedCode, CancellationToken cance
ReplaceIndexersByMethodsWithParameter(
generatedCode,
false,
static x => $"With{x.ToFirstCharacterUpperCase()}",
static x => $"By{x.ToFirstCharacterUpperCase()}",
static x => x.ToFirstCharacterLowerCase());
FlattenNestedHierarchy(generatedCode);
FlattenGoParamsFileNames(generatedCode);
Expand Down
854 changes: 427 additions & 427 deletions src/Kiota.Builder/Refiners/JavaRefiner.cs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Kiota.Builder/Refiners/PhpRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public override Task Refine(CodeNamespace generatedCode, CancellationToken cance
MakeModelPropertiesNullable(generatedCode);
ReplaceIndexersByMethodsWithParameter(generatedCode,
false,
static x => $"With{x.ToFirstCharacterUpperCase()}",
static x => $"By{x.ToFirstCharacterUpperCase()}",
static x => x.ToFirstCharacterLowerCase());
cancellationToken.ThrowIfCancellationRequested();
MoveClassesWithNamespaceNamesUnderNamespace(generatedCode);
Expand Down
2 changes: 1 addition & 1 deletion src/Kiota.Builder/Refiners/PythonRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public override Task Refine(CodeNamespace generatedCode, CancellationToken cance
cancellationToken.ThrowIfCancellationRequested();
ReplaceIndexersByMethodsWithParameter(generatedCode,
false,
static x => $"_with_{x.ToSnakeCase()}",
static x => $"by_{x.ToSnakeCase()}",
static x => x.ToSnakeCase());
RemoveCancellationParameter(generatedCode);
CorrectCoreType(generatedCode, CorrectMethodType, CorrectPropertyType, CorrectImplements);
Expand Down
2 changes: 1 addition & 1 deletion src/Kiota.Builder/Refiners/RubyRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public override Task Refine(CodeNamespace generatedCode, CancellationToken cance
cancellationToken.ThrowIfCancellationRequested();
ReplaceIndexersByMethodsWithParameter(generatedCode,
false,
static x => $"_with_{x.ToSnakeCase()}",
static x => $"by_{x.ToSnakeCase()}",
static x => x.ToSnakeCase());
MoveRequestBuilderPropertiesToBaseType(generatedCode,
new CodeUsing
Expand Down
2 changes: 1 addition & 1 deletion src/Kiota.Builder/Refiners/SwiftRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public override Task Refine(CodeNamespace generatedCode, CancellationToken cance
ReplaceIndexersByMethodsWithParameter(
generatedCode,
false,
static x => $"With{x.ToFirstCharacterUpperCase()}",
static x => $"By{x.ToFirstCharacterUpperCase()}",
static x => x.ToFirstCharacterUpperCase());
cancellationToken.ThrowIfCancellationRequested();
ReplaceReservedNames(
Expand Down
2 changes: 1 addition & 1 deletion src/Kiota.Builder/Refiners/TypeScriptRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public override Task Refine(CodeNamespace generatedCode, CancellationToken cance
});
ReplaceIndexersByMethodsWithParameter(generatedCode,
false,
static x => $"with{x.ToFirstCharacterUpperCase()}",
static x => $"by{x.ToFirstCharacterUpperCase()}",
static x => x.ToFirstCharacterLowerCase());
RemoveCancellationParameter(generatedCode);
CorrectCoreType(generatedCode, CorrectMethodType, CorrectPropertyType, CorrectImplements);
Expand Down