fixes edge case for inheritance description #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papegaaij
requested review from
andrueastman,
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
ramsessanchez,
calebkiage,
Ndiritu,
rkodev,
gavinbarron,
coseguera and
koros
as code owners
baywet
force-pushed
the
broken-inheritance
branch
from
6d2068e to
bc7650d
Compare
This is described in microsoft#2781
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
force-pushed
the
broken-inheritance
branch
from
bc7650d to
8a94e84
Compare
|
@papegaaij Thank you a lot for your extended patience on this one. It took me a while to go through my backlog and get to this... The simple was fairly simple and didn't have side effects on other aspects as you can see. @rkodev @andrueastman since I made some of the code changes here, I'm not going to review it. Letting one of you review and merge it. |
baywet
changed the title
andrueastman
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is described in #2781