Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/multi content types #3453

Merged
merged 35 commits into from
Oct 19, 2023
Merged

feature/multi content types #3453

merged 35 commits into from
Oct 19, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 6, 2023

fixes #3377

@baywet baywet self-assigned this Oct 6, 2023
@baywet baywet force-pushed the feature/multi-content-types branch 3 times, most recently from 50361a7 to a6a3683 Compare October 11, 2023 15:02
@baywet baywet marked this pull request as ready for review October 11, 2023 15:02
@baywet baywet requested a review from a team as a code owner October 11, 2023 15:02
@baywet baywet enabled auto-merge October 11, 2023 15:02
@baywet baywet mentioned this pull request Oct 11, 2023
Merged
andrueastman
andrueastman previously approved these changes Oct 12, 2023
View reviewed changes
@baywet baywet force-pushed the feature/multi-content-types branch from 5873c09 to f48c46e Compare October 12, 2023 12:27
andrueastman
andrueastman previously approved these changes Oct 12, 2023
View reviewed changes
@calebkiage
Copy link
Contributor

calebkiage commented Oct 12, 2023 •
edited
Loading

There's 1 relevant code smell warning on SonarCloud I agree with.

Refactor 'StructuredMimeTypes' into a method, properties should not copy collections.

@baywet baywet disabled auto-merge October 16, 2023 13:20
@baywet
Copy link
Member Author

baywet commented Oct 16, 2023

There's 1 relevant code smell warning on SonarCloud I agree with.

Refactor 'StructuredMimeTypes' into a method, properties should not copy collections.

@calebkiage Thanks for the prompt, I had missed this one. The right thing to do was to cleanup the old list to avoid mix-ups. I just fixed that.

@baywet baywet enabled auto-merge October 16, 2023 13:36
andrueastman
andrueastman previously approved these changes Oct 17, 2023
View reviewed changes
@andrueastman
Copy link
Member

@baywet I suspect we need to bump the abstraction dependencies for the go and java integration test projects to unblock the failing CI.

@baywet
- moves content type related tests to a dedicated file
b98a339
@baywet
- adds missing configuration parsing for exclude backward compatible
5bf17a4 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- restricts visibility of internal methods
008bc77 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds a data structure to parse priority and maintain ordering for m…
f7ab0e8 
…ime types

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- maps lookups to new data strucutre
d9cae7a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes unit tests after swapping to the ordered manager
99e3c3c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- removes redundant tolist
f7410f1 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- updates the label for the structured mime types definition
25c20d1 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds multiple accept support
d8cc3fc 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- refactors use of accept values
3635111 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- finalizes accept multi-value header implementation
7bca910
@baywet
- sets content type for multiple structured entries
71e40c2 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds additional request body content type parameter to generation
24e5501 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds support for ambiguous content type in CSharp
5940ba8 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes formatting
d441dc5
@baywet
- adds content type parameter support for java
48a0197
@baywet
- adds content type parameter support for go
24cecd9
@baywet
- adds content type parameter support for typescript
c6f3958
@baywet
- adds content type parameter support for php
d0bd24a
@baywet
- adds content type parameter support for python
c0bee29
@baywet
- adds content type parameter support for ruby
af1aa24
@baywet
- adds changelog entry for multiple content types
56fd099
@baywet
- adds defensive statement for reference comparisons
787a0a9
@baywet
- replaces list concrete type by interface
484696e
@baywet
- adds missing doc comments
4083f0c
@baywet
- refactors collections between orderedstructuredmimetypes and the no…
dd53831 
…n ordered one

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet force-pushed the feature/multi-content-types branch from ce24f70 to dd53831 Compare October 17, 2023 13:02
@baywet
Copy link
Member Author

baywet commented Oct 17, 2023

@andrueastman yep, I was waiting for #3401 to be merged since the update had already been made in there and since there'd be conflicts to resolve

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

84.0% 84.0% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit f19dec5 into main Oct 19, 2023
173 checks passed
@baywet baywet deleted the feature/multi-content-types branch October 19, 2023 14:47
@baywet baywet mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu approved these changes

@andrueastman andrueastman andrueastman left review comments

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Content-Type body contents are not handled
4 participants
@baywet @calebkiage @andrueastman @Ndiritu