-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Check for missing translations #5604
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good check.
@thewahome quick spot check. The generated artifact shows this output and I believe it's a false positive? The strings are present in the I10n folder files for the languages. Also, there's some duplication on strings like OK, a single return is more clearer? |
Thanks @musale and @baywet for taking the time to look at it. I hadn't appropriately marked this as a draft. And it's currently in POC. Your input is greatly appreciated as it will go along way in making sure that the work is complete. I am also going to add an issue so that this work is triaged and tracked. |
Co-authored-by: Caleb Kiage <747955+calebkiage@users.noreply.github.com>
Quality Gate passed for 'kiota'Issues Measures |
Overview
It's easy to forget to update the translation files after a feature is done. It would help us to add a new check to show us the missing translations available
Closes #5607
Notes
Introduces a script file that checks the missing translations and generates readable text for the items
Demo