fix: disables signed commits as it blocks dependabot #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
turns out dependabot signs commits. Using GitHub's UI to rebase "removes" the signature. Requiring signature is still going to be a problem for OSS contributors who have not enabled it, so I'm not sure we should keep it? I wished that policy definition was a bit more fine grained to allow us to require it only for people listed out in the code owners... |
Ndiritu
approved these changes
Jan 14, 2025
andrueastman
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
I'm cool with disabling this for now. On top of the reasons highlighted, this would be inconsistent with the other repos we have. (I think it would be best if we were consistent across our open-source repos as the change would also require alignment with the current team members as well)
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #6001, #6000