Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go core libraries #716

Merged
merged 49 commits into from
Nov 1, 2021
Merged

go core libraries #716

merged 49 commits into from
Nov 1, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 13, 2021

Summary

fixes #468, #465, #464, #463

  • adds azure identity go library
  • adds http client implementation for go
  • leverages reference to default factory for serialization in go request adapter - implements body for go request adapter
  • adds workflows for go http and auth - updates readmes for go http

Generation diff

microsoft/kiota-samples#364

@baywet baywet added this to the TypeWriter Replacement milestone Oct 13, 2021
@baywet baywet added the Go label Oct 13, 2021
@baywet baywet self-assigned this Oct 13, 2021
@baywet baywet marked this pull request as ready for review October 19, 2021 20:08
@baywet baywet force-pushed the feature/go-auth branch 3 times, most recently from 01bcdbc to 9cde5f0 Compare October 22, 2021 12:56
@baywet baywet linked an issue Oct 25, 2021 that may be closed by this pull request
Base automatically changed from feature/url-template to main October 27, 2021 12:21
@baywet
Copy link
Member Author

baywet commented Oct 28, 2021

@andrueastman FYI the major revamp on middleware infrastructure is done thanks to @jobala suggestion. Now the only thing that's left is to add a retry handler and parameter set support.

http/go/nethttp/retry_handler.go Show resolved Hide resolved
http/go/nethttp/pipeline.go Outdated Show resolved Hide resolved
@baywet
Copy link
Member Author

baywet commented Oct 29, 2021

@andrueastman we should be good to go for final review at this point. Thanks for the continuous support.

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save for the active comments, this looks good to me.

http/go/nethttp/redirect_handler.go Outdated Show resolved Hide resolved
http/go/nethttp/pipeline.go Show resolved Hide resolved
andrueastman
andrueastman previously approved these changes Nov 1, 2021
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.8% 88.8% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit ba946bc into main Nov 1, 2021
@baywet baywet deleted the feature/go-auth branch November 1, 2021 17:08
@baywet baywet linked an issue Nov 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants