Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Virtual Terminal mode on legacy Windows terminal to support ANSI escape sequences #265

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Aug 15, 2022

Migrated from Azure/azure-cli#12942

This PRs totally removes colorama, getting us rid of colorama bugs.

Windows versions before Windows 10 1607 are not supported anymore. Colors are automatically disabled on those jurassic period terminals 🦖.

When Windows Terminal becomes universal, even _win_vt.py should be dropped.

Comment on lines -252 to -255
if self._should_init_colorama:
import colorama
colorama.deinit()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any side effect if we don't disable it.

@jiasli jiasli marked this pull request as ready for review August 18, 2022 03:55
@jiasli jiasli merged commit c44be5f into microsoft:dev Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants