Don't add to graph scripts missing from package.json #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid adding packages to build graph when not specified. This will be highly impactful for our build times of our PR Deployment environment as we'd be able to just bundle packages, we deploy to this environment instead of the full repo. In our build pipelines where we need to build everything, we can add
build
to the Lage tasks.Manual Validation
Within our team's repo, I was able to confirm that running
lage test
ran all test tasks our team has, and avoided building packages without tests and that were not in any dependency path. We went from having to build 117 packages to 108.I can share the results with you privately to avoid sharing any private package names here :)
Fixes #592