Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] update the code for newest pyceres #12

Merged
merged 2 commits into from
Dec 14, 2022
Merged

[Bug Fix] update the code for newest pyceres #12

merged 2 commits into from
Dec 14, 2022

Conversation

foreverYoungGitHub
Copy link
Contributor

Hi, @skydes,

Thanks for your great work!

I found a small bug and fixed it in this PR, which is caused by the newest pyceres changes.

Hope that works for you!

Best,
Yang

@foreverYoungGitHub
Copy link
Contributor Author

@microsoft-github-policy-service agree

sarlinpe
sarlinpe approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! @Phil26AT We should add versioning to pyceres.

@sarlinpe sarlinpe merged commit 4a37cdb into microsoft:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

@omiksik omiksik Awaiting requested review from omiksik omiksik is a code owner

@pablospe pablospe Awaiting requested review from pablospe pablospe is a code owner

@mihaidusmanu mihaidusmanu Awaiting requested review from mihaidusmanu mihaidusmanu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foreverYoungGitHub @sarlinpe