Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed trace for NavVis M6 devices. #66

Merged
merged 2 commits into from
May 17, 2024
Merged

Fixed trace for NavVis M6 devices. #66

merged 2 commits into from
May 17, 2024

Conversation

pablospe
Copy link
Contributor

Contrary to the VLX where cam_head is the sensor_frame.xml coordinate system, in the M6 is footprint. This adapts the trace to M6 to footprint, while keeping the VLX in cam_head.

@pablospe pablospe requested review from vjlux and MarioGini May 16, 2024 20:26
vjlux
vjlux approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@vjlux vjlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pablospe pablospe merged commit 0846a07 into main May 17, 2024
2 checks passed
@pablospe pablospe deleted the pablospe/trace_fix_for_M6 branch May 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjlux vjlux vjlux approved these changes

@MarioGini MarioGini Awaiting requested review from MarioGini

@omiksik omiksik Awaiting requested review from omiksik omiksik is a code owner

@mihaidusmanu mihaidusmanu Awaiting requested review from mihaidusmanu mihaidusmanu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablospe @vjlux