Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "labels" to ApplyWorkspaceEditParams #243

Closed
mickaelistria opened this issue May 9, 2017 · 3 comments
Closed

Add "labels" to ApplyWorkspaceEditParams #243

mickaelistria opened this issue May 9, 2017 · 3 comments
Labels
feature-request Request for new features or functionality
Milestone
November 2017

Comments

@mickaelistria
Copy link

In order to easily use edits in place of commands here and there, and in order to provide nice labels in the undo/redo stack for operations provided by the LSP, it could be interesting to add an optional "label" field to Workspace and TextEdits.
@dbaeumer dbaeumer added this to the 4.0 milestone May 17, 2017
@dbaeumer
Copy link
Member

Makes sense.

@mickaelistria mickaelistria mentioned this issue May 17, 2017
Closed
@dbaeumer
Copy link
Member

Instead of generically naming edits we should add a name to ApplyWorkspaceEditParams. This can then be used to construct a name for the Undo.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Nov 22, 2017
@dbaeumer dbaeumer modified the milestones: 4.0, November 2017 Nov 22, 2017
@dbaeumer
Copy link
Member

Actually this was easy to address. So I added an optional name to the ApplyWorkspaceEditParams.

@dbaeumer dbaeumer changed the title Add "labels" to edits Add "labels" to ApplyWorkspaceEditParams Nov 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
vladdu pushed a commit to vladdu/language-server-protocol that referenced this issue Jan 26, 2021
@dbaeumer @vladdu
Fixes microsoft#243: Add "labels" to ApplyWorkspaceEditParams
0cc774c
sam-mccall pushed a commit to sam-mccall/language-server-protocol that referenced this issue Apr 20, 2021
@dbaeumer @sam-mccall
Fixes microsoft#243: Add "labels" to ApplyWorkspaceEditParams
6b3ea9b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@mickaelistria @dbaeumer