Add inlay hint support #1339
Closed
Add inlay hint support #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
dupe of #1249 ? |
rcjsuen
reviewed
Sep 3, 2021
Comment on lines
+9027
to
+9040
| /** | ||
| * The kind of this hint. | ||
| */ | ||
| kind?: InlayHintKind; | ||
|
|
||
| /** | ||
| * Whitespace before the hint. | ||
| */ | ||
| whitespaceBefore?: boolean; | ||
|
|
||
| /** | ||
| * Whitespace after the hint. | ||
| */ | ||
| whitespaceAfter?: boolean; |
There was a problem hiding this comment.
Can we include a note in the comment that states what happens when these optional fields are omitted?
|
@matklad that hasn't been aligned to what vscode implemented and hasn't been updated since 8th June, which this PR is aligned to and I raised it based off this comment #956 (comment). I would be fine with #1249 being aligned to what shipped in vscode. All I want to do is get the feature added, by hook or crook. |
|
Also @matklad this comment seems to indicate that the PR is "obsolete" but left up to @dbaeumer to close when appropriate: #1249 (comment) |
|
Yes, I think we should continue in #1249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #956