Skip to content

Commit

Permalink
Ninja: comment abitrary kernel version cutoff
Browse files Browse the repository at this point in the history
Add comment about the entirely arbitrary kernel version
cutoff. It's used to decide whether to use the package manager
or install from pip. It's based on what's needed for DPDK,
so eventually the condition may change to be more specific based
on LISA's need.
  • Loading branch information
mcgov committed Sep 24, 2024
1 parent 32b6679 commit 37949ca
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lisa/tools/ninja.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ def can_install(self) -> bool:

def _install(self) -> bool:
node = self.node
# entirely arbitrary kernel version cutoff
# to seperate older distros (pre-2020) from newer ones
# that package recent versions of ninja.
if (
isinstance(self.node.os, Posix)
and self.node.os.get_kernel_information().version >= "5.15.0"
Expand Down

0 comments on commit 37949ca

Please sign in to comment.