Allow guests to open shared terminals in a split terminal

[anthonytec2]

Currently when you share terminals you get discrete terminals for each set shared. I would like to have the ability to place the terminals side by side next to each other.

[IlyaBiryukov]

Hi,

Thanks for your suggestion. I assume you're asking about the guest side in VSCode?

The host already can share terminals side-by-side when liveshare.autoShareTerminals VSCode setting is true, which is the default, and the guest clicks on Split Terminal.

However, when the guest clicks on Split Terminal command, VSCode just starts a local terminal. This cannot start another shared terminal for two reasons:

1. VSCode doesn't allow extension to configure of what the split terminal should be
2. Guest doesn't have permission to start a new shared terminal in collaboration session for security reasons.

[lostintangent]

@IlyaBiryukov One thing we could do is add a new action button to the viewlet that allows guests to open a shared terminal in a new split terminal, as opposed to a regular terminal. That way the decision of when to open a terminal in split or “full” mode is a UI decision of the guest, as opposed to something enforced by the host.

This new action could be called “Open Split Terminal”, and would be available as both a context menu and “row icon” for shared terminal instances in the explorer view.

@anthonytec2 Thoughts? What that accommodate your use case? We can use this issue to track this discussion/proposal.

[anthonytec2]

My main use case is currently when I am working with a partner they may have two terminals open that are side by side in their view. Although, on my view I can only see these terminals as two separate full view terminals. I would love to have the ability from the guest side to have a split view with both of the two terminals like the host view.

[IlyaBiryukov]

@lostintangent we'd need support from VSCode if we want to enable this in Live Share. Something like an ability to open a new terminal window alongside the existing one, in a split terminal, instead of a regular window where a new terminal usually goes to.

[carlmanaster]

@IlyaBiryukov Could you open a request for this support in VSCode? I think the request would have more weight and more relevance coming from the Live Share team.

[IlyaBiryukov]

Already did. Here it is
microsoft/vscode#45218

[carlmanaster]

Thanks!

…

On Fri, Mar 22, 2019 at 10:27 AM Ilya Biryukov ***@***.***> wrote: Already did. Here it is microsoft/vscode#45218 <microsoft/vscode#45218> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1205 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM-UXugT56yNuFemP4djeLIOseclvfJks5vZRKFgaJpZM4X8LQh> .

-- http://undisclosed-recipients.blogspot.com http://www.flickr.com/photos/carlmanaster/sets/228603/

[rispeed]

I was looking for the same thing, a way to join two existing terminals together into a split

[lostintangent]

Closing this due to a lack of any recent customer feedback. Please re-open if you still think this is something we should address. Thanks!

[StummeJ]

Was there ever a solution for this. It's super annoying to have a yarn serve in one terminal and tests in another but not be able to join them

[neodon]

This is a constant source of annoyance and confusion when I am pairing with someone. I have 2-3 terminals open that are split, and they can only see one at a time. I would use focus terminal so they could follow what I'm doing, but that doesn't work (at least when using the Remote SSH extension + LiveShare).

Can you have another look into this? For us it's the only downside to an otherwise polished and productive pairing solution.

[lostintangent]

VS Code now allows terminals to be moved into split terminals, and so a guest has the flexibility to configure the "position" of a shared terminal however they'd like 🚀 As a result, I'm going to close this as resolved, but please let us know if folks have any issues/feedback in this area. Thanks!