Malformed env variables in debug mode using integrated terminal

[bcanseco]

I have emailed my zipped logs to vsls-feedback@microsoft.com

Product and Version [VS/VSCode]: VSCode 1.22.2
OS Version [macOS/Windows]: macOS 10.13.4
Live Share Extension Version: 0.2.547
Target Platform or Language [e.g. Node.js]: Node.js

Brief description:
If you start the VS Code debugger with console set to integratedTerminal, then it looks like any variables in the env dictionary are sent to the shell with weird casing.

cd /vsls-repro ; env "nodE_ENV=development" /usr/local/bin/node --inspect-brk=29328 app.js

With VS Live Share disabled:

cd /vsls-repro ; env "NODE_ENV=development" /usr/local/bin/node --inspect-brk=19467 app.js

Steps to Reproduce / Scenario:

1. git clone https://github.com/bcanseco/vsls-repro
2. cd vsls-repro
3. code .
4. Verify that the VS Live Share extension is installed and enabled (disable any others)
5. CMD+SHIFT+D (or click the Debug button)
6. Start debugging the Launch Program configuration
7. Observe that Should be true: false was outputted in the integrated terminal.
8. Open .vscode/launch.json and make the following change:

-"console": "integratedTerminal",
+"console": "internalConsole",

9. Start debugging the edited Launch Program configuration.
10. Observe that Should be true: true was outputted in the debug console.
11. Disable the VS Live Share extension and reload VS Code.
12. Repeat steps 5-10 and observe that Should be true: true is logged in both scenarios.

[lostintangent]

@bcanseco Thanks for reporting this, and providing such a thorough repro. We haven’t seen this issue before, but will look it using the logs you sent. Stay tuned!

[lostintangent]

This has been fixed in the latest extension release. Let us know if it still repros after you update. Thanks again for reporting it!