Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow mode UX #281

Closed
jmaicaaan opened this issue May 3, 2018 · 6 comments
Closed

Follow mode UX #281

jmaicaaan opened this issue May 3, 2018 · 6 comments

Comments

@jmaicaaan
Copy link

Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: macOS
Live Share Extension Version: 0.2.547
Target Platform or Language [e.g. Node.js]: Node.js

Steps to Reproduce / Scenario:

  1. Host a session and pair with your programming partner
  2. Let your programming partner change file

When your paired partner changed some files, it opens the file on a new tab which is expected. But when you open the file that your partner changed, it doesn't scroll you to the changed line.

I believe it would be better if someone changed some files and then you went to the changed file. You are automatically "focus" or "scrolled" to the line changed.

That is the only thing I've seen so far in my first few minutes. I'll give some feedbacks later on. Good job on the team 👍

@Chuxel
Copy link
Member

Chuxel commented May 3, 2018

@jmaicaaan Live Share should be automatically jumping to the location the host is currently located so that the host can explain what is going on even if they are not in a location where they've made an edit.

Is that not happening for you?

@jmaicaaan
Copy link
Author

Hi @Chuxel ,

It actually jump into the file but the focus of the screen is at the bottom. My paired partner, made some changes at the top of the code but when it jumps into the changed file the focus is at the bottom, not on the exact location of paired partner is editing. Which is a little off in terms of UX.

@Chuxel
Copy link
Member

Chuxel commented May 3, 2018

@jmaicaaan Just to make sure I understand - The question is what your partner's scroll position was at the exact moment when you joined. Since that is synchronized, we will go to exactly what they are looking at not the last edit. Even if we went to the last edit location, the moment your partner touched the scroll bar we'd snap back to that location.

Is the issue that you're prefer not to synchronize scrolling?

@jmaicaaan
Copy link
Author

@Chuxel, this is the scenario we had, I, the host, created the session. I don't have any opened files yet. Then my partner goes to a file where it has a long line of code. It has 3000 lines of code to be exact. Then my partner made some changes at the bottom of the file.

Vscode's behavior was it opened the edited file but it didn't scroll to the exact position on where my partner does some changes. And yes, it is an issue regarding synchronizing scrolling.

@daytonellwanger
Copy link
Collaborator

Hey @jmaicaaan , thanks for the feedback. Since you left it we've done a lot of work to make "follow mode" behave more as you described. Could you give it another shot and let us know if you're still unsatisfied with the expereince? Thanks!

@daytonellwanger daytonellwanger self-assigned this Apr 8, 2019
@daytonellwanger daytonellwanger changed the title UX on pair change file Follow mode UX Jul 31, 2019
@lostintangent
Copy link
Member

We've made a lot of changes to follow mode since this issue was last filed, including the ability to follow another user's scroll position. So I'm going to close this for now, under the assumption that it's resolved. Please re-open it if you continue to have feedback on our current UX. Thanks!

learn-build-service-prod bot pushed a commit that referenced this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@lostintangent @Chuxel @daytonellwanger @Priya91 @jmaicaaan @fubaduba and others