Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libssl-dev on Ubuntu #3044

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Use libssl-dev on Ubuntu #3044

merged 3 commits into from
Dec 13, 2019

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Dec 9, 2019

Fixes #2812

Use libssl-dev instead of hard-coding the version of libssl for every Ubuntu release. libssl-dev is available in Ubuntu going back to 16.04:
https://packages.ubuntu.com/search?keywords=libssl-dev

@msftclas
Copy link

msftclas commented Dec 9, 2019

CLA assistant check
All CLA requirements met.

@brylie
Copy link
Contributor Author

brylie commented Dec 9, 2019

@IlyaBiryukov
Copy link
Collaborator

It's kind of awkward for an application to take a dependency over a developer api lib. I think we should hard code the version of libssl for every supported Ubuntu release. And, of course, document explicitly what releases are supported.

@brylie
Copy link
Contributor Author

brylie commented Dec 10, 2019

From what I can tell, the libssl-dev seems to be a metapackage for the latest stable version of the package as well as suggesting installing docs.

This issue stems from the installation script not being kept up-to-date with supported Ubuntu releases and newer libssl releases. How will the installation script/documentation be kept up-to-date to reflect supported libssl releases and Ubuntu versions?

@brylie
Copy link
Contributor Author

brylie commented Dec 10, 2019

Another alternative on Ubuntu would be to use the openssl package.

The idea being to avoid the script going out of date by relying on a stable Ubuntu package name or metapackage.

@IlyaBiryukov
Copy link
Collaborator

There is a bunch of /usr/include/openssl/*.h files in the list of files or libssl-dev.

Dotnet core dependencies have libssl, and say nothing about openssl, up until it gets supported in 3.0, as declared in Whats new in .NET Core 3.0.
We don't have plans to migrate to dotnet core 3.0 yet.

So the only option is to use libssl.

@IlyaBiryukov
Copy link
Collaborator

Actually, I see that dotnet core guys back ported openssl 1.0 and 1.1. support to dotnet 2.1 with this PR.
So using openssl may be an option then.

@IlyaBiryukov
Copy link
Collaborator

cc @jasongin

@brylie
Copy link
Contributor Author

brylie commented Dec 10, 2019

I changed the script to use openssl.

@IlyaBiryukov
Copy link
Collaborator

We're going to test the updated script a little bit, and then it'll be good to go.

@IlyaBiryukov IlyaBiryukov merged commit b3196e2 into microsoft:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Extension is requiring libssl1.0.0 on Ubuntu 19.04
3 participants