Add CoreCLR personality function and EH table emission #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2015
For callers that have the name of the personality routine but not a corresponding Value.
JosephTremoulet
force-pushed
the
EmitCatch
branch
2 times, most recently
from
1fe215b
to
a90e211
Compare
|
Something along the lines of |
| assert(isa<CleanupHandler>(Action)); | ||
| Current->CatchType = 0; | ||
| } else { | ||
| assert(isa<Operator>(TheCatchHandler->getSelector()) && "Expected IntToPtr(handkerToken)"); |
|
LGTM, just a few small notes. |
JosephTremoulet
force-pushed
the
EmitCatch
branch
from
a90e211
to
5a411e3
Compare
Processing happens in two stages (as for other WinEH personalities): - FunctionLoweringInfo::set computes the parent relation on handler actions. ClrEHFuncInfo is added to MachineModuleInfo to facilitate this. - WinException::endFunction reports funclet begin/end offsets in .xdata after unwind info, and reports EH clauses after the final funclet's unwind info. Note: this is a provisional change to facilitate exploring exception handling in LLILC, and will need to be reworked when LLVM's EH representation is changed for Windows-style targets -- see http://thread.gmane.org/gmane.comp.compilers.llvm.devel/85783
JosephTremoulet
force-pushed
the
EmitCatch
branch
from
5a411e3
to
b289459
Compare
|
Updated as suggested; merging into EH branch. |
JosephTremoulet
added a commit
that referenced
this pull request
Jun 8, 2015
Add CoreCLR personality function and EH table emission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for changes going into the newly-created EH branch. The purpose is to park the changes-so-far based on the soon-to-be-abandoned WinEH approach of using Itanium-style IR paired with funclet outlining in WinEHPrepare. Support will be reworked when the new IR representation lands. I'm going to shift focus to aspects of EH that are independent of the impending rewrite (e.g. filter function outlining). Putting these changes here lets anyone curious see where things are/were heading and provide feedback, and lets me park similar changes dependent on this in the EH branch of LLILC.