Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Moniker #63

Merged
merged 18 commits into from
Sep 4, 2020
Merged

Support Moniker #63

merged 18 commits into from
Sep 4, 2020

Conversation

CsCherrYY
Copy link
Contributor

This PR is to support monikers and packageInfomation in LSIF-Java. For more information, Please see
https://microsoft.github.io/language-server-protocol/specifications/lsif/0.5.0/specification/

jdneo
jdneo requested changes Aug 13, 2020
View reviewed changes
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
@CsCherrYY
Apply changes
de62e4d 
1. Merge PackageInformation Maps in Repository
2. Use `org.apache.maven.scm.provider.ScmUrlUtils` to resolve scm
3. Support Both Java8- and Java9+
4. Rename `project` moniker to `group` moniker
5. Rewrite some codes
jdneo
jdneo requested changes Aug 19, 2020
View reviewed changes
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
@CsCherrYY
Apply changes
726779c 
1. handle together for different JDK distributions
2. Use `IMaven.readProject` to get effective pom information
@CsCherrYY CsCherrYY requested a review from jdneo August 21, 2020 09:01
jdneo
jdneo requested changes Aug 24, 2020
View reviewed changes
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated Show resolved Hide resolved
...ft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/protocol/PackageInformation.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
@CsCherrYY
Apply changes
00b55ac 
1. Remove useless `ProjectBuildTool` and unified all the manager to `maven`
2. Rewrite logic of finding pom and export monikers of maven project.
3. other fix
@CsCherrYY CsCherrYY requested a review from jdneo August 25, 2020 06:32
@CsCherrYY
Apply changes
61e466d 
1. Use binding to get modifiers
2. Resolve visibility of enum
3. clean and enhance codes
@CsCherrYY CsCherrYY requested a review from jdneo August 27, 2020 09:48
@CsCherrYY
Apply comments
85c6686 
1. Remove bindingsRecovery
2. Divides read and write in packageinformation
3. Fix Enum modifier bug
4. Fix an NPE bug when the connection of a scm is null
@CsCherrYY CsCherrYY requested a review from jdneo August 31, 2020 08:47
@CsCherrYY
Apply changes
57b1db5 
1. Adjust assignment of monikerKind
2. Resolve comments
jdneo
jdneo requested changes Sep 1, 2020
View reviewed changes
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
@CsCherrYY
Apply changes
1dece7c 
1. Extract a method to initialize manager
2. Extract a method to resolve a SimpleName/SimpleType
3. apply other comments
@CsCherrYY CsCherrYY requested a review from jdneo September 1, 2020 07:46
@CsCherrYY
Update LsifVisitor.java
baa070e 
Rewrite resolve logics
jdneo
jdneo requested changes Sep 2, 2020
View reviewed changes
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated Show resolved Hide resolved
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated Show resolved Hide resolved
@CsCherrYY
Apply changes
cfed442 
1. Move `resolveMoniker` to SymbolData.java
2. NULL check once have gotten values
@CsCherrYY CsCherrYY requested a review from jdneo September 2, 2020 07:23
jdneo
jdneo approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo merged commit 4b47502 into microsoft:master Sep 4, 2020
@jdneo jdneo added this to the 0.4.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CsCherrYY @jdneo