Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing hook for Semantic Token capabilities. #98

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Add missing hook for Semantic Token capabilities. #98

merged 3 commits into from
Oct 18, 2022

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 18, 2022 •
edited
Loading

Closes #95

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Oct 18, 2022
@karthiknadig karthiknadig requested a review from karrtikr October 18, 2022 21:39
@karthiknadig karthiknadig self-assigned this Oct 18, 2022
@karrtikr
Copy link

Lint still appears to be failing.

@karthiknadig
Copy link
Member Author

@karrtikr fixed linting.

@karthiknadig karthiknadig merged commit 8a36217 into microsoft:main Oct 18, 2022
@karthiknadig karthiknadig deleted the bugs branch October 18, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@karthiknadig karthiknadig

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with parsing SemanticTokensClientCapabilitiesRequestsType
2 participants
@karthiknadig @karrtikr