Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catching pydub's warning of ffmpeg or avconv missing #39

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Catching pydub's warning of ffmpeg or avconv missing #39

merged 3 commits into from
Dec 16, 2024

Conversation

SH4DOW4RE
Copy link
Contributor

Made a small PR to catch pydub's warning of ffmpeg and avconv missing and used it to also disable audio transcript.

Connected issue #21

@SH4DOW4RE
Copy link
Contributor Author

@microsoft-github-policy-service agree

@gagb
Copy link
Contributor

gagb commented Dec 15, 2024 •
edited
Loading

Can you please run pre-commit? 'pre-commit run --all-files'

@SH4DOW4RE
Copy link
Contributor Author

SH4DOW4RE commented Dec 15, 2024 •
edited
Loading

where do i run that ? (first time seeing pre-commit)
Never mind i found it, just pushed a new commit after running pre-commit

@gagb gagb self-requested a review December 16, 2024 23:24
@gagb gagb merged commit e7a2e20 into microsoft:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagb gagb gagb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SH4DOW4RE @gagb