Skip to content

Conversation

@jumacabo
Copy link
Contributor

What does this PR do?

This PR makes PostgreSQL tool to mandatorily require SSL and verify the server's full certificate chain.

See VerifyFull for more info.

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@jumacabo jumacabo added the bug Something isn't working label Oct 31, 2025
@jumacabo jumacabo added the tools-Postgres PostgreSQL label Oct 31, 2025
@jumacabo jumacabo marked this pull request as ready for review October 31, 2025 11:05
@jumacabo jumacabo requested review from a team, kk-src and xiangyan99 as code owners October 31, 2025 11:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances PostgreSQL connection security by enforcing SSL certificate verification. The change adds explicit SslMode.VerifyFull configuration to the connection string builder before creating database connections.

Key changes:

  • Sets SslMode.VerifyFull for all PostgreSQL connections to enforce full certificate verification
  • Uses NpgsqlConnectionStringBuilder to modify the connection string before creating the data source

@joshfree joshfree added this to the 2025-11 milestone Oct 31, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tools-Postgres PostgreSQL

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants