Skip to content

Conversation

@g2vinay
Copy link
Contributor

@g2vinay g2vinay commented Nov 4, 2025

Updates VSIX to register version, to prompt refresh of tools in VS code iDE.

Copilot AI review requested due to automatic review settings November 4, 2025 18:01
@g2vinay g2vinay requested review from a team as code owners November 4, 2025 18:01
@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds version tracking to the Azure MCP Server by passing the package version from package.json to the McpStdioServerDefinition constructor. This enables better versioning and tracking of the MCP server instance.

  • Added packageJson constant at module level to read version from package.json
  • Updated McpStdioServerDefinition constructor call to include the version parameter
Comments suppressed due to low confidence (1)

servers/Azure.Mcp.Server/vscode/src/extension.ts:1

  • The test mock for MockMcpStdioServerDefinition doesn't include the new version parameter in its constructor signature. This mock should be updated to accept a version parameter (even if unused) to match the actual API being called, ensuring tests accurately reflect the production code.
// Copyright (c) Microsoft Corporation. All rights reserved.

import * as path from 'path';
import * as fs from 'fs';

const packageJson = require('../../package.json');
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using require() for JSON imports is not AOT-safe and uses CommonJS syntax. Replace with an ES module import using import packageJson from '../../package.json' assert { type: 'json' }; or use import packageJson from '../../package.json'; if the TypeScript configuration supports JSON module resolution.

Copilot generated this review using guidance from repository custom instructions.
@joshfree joshfree added tools-VSIX VS Code Marketplace Setup customer-reported 1.x labels Nov 4, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Nov 4, 2025
@joshfree joshfree added this to the 2025-11 milestone Nov 4, 2025
@joshfree
Copy link
Member

joshfree commented Nov 4, 2025

Let's backport this to 1.x too

Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog - make it REALLY clear that this is an important fix

@JasonYeMSFT
Copy link
Member

You may ping owners of other MCP servers to check this as well. Or you can check it for them.

@hallipr
Copy link
Member

hallipr commented Nov 4, 2025

Should we have a common module for use by the servers' extension.ts files? I feel like there's going to be a large amount of code that's just copy-pasted between servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.x customer-reported tools-VSIX VS Code Marketplace Setup

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants