Skip to content

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Nov 5, 2025

What does this PR do?

Scripts in eng/npm were still hardcoded for @azure/mcp. These should be dynamic and support all the servers we publish

GitHub issue number?

Partial fix for #450

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copilot AI review requested due to automatic review settings November 5, 2025 22:50
@hallipr hallipr requested review from a team as code owners November 5, 2025 22:50
@hallipr hallipr requested a review from joshfree November 5, 2025 22:50
@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the npm wrapper script more generic and maintainable by removing hardcoded references to @azure/mcp and dynamically deriving the package name from package.json. It also updates the DEBUG environment variable check, troubleshooting instructions, and ensures version consistency when installing platform-specific packages.

Key Changes:

  • Dynamically reads package name and version from package.json instead of hardcoding @azure/mcp
  • Updates DEBUG environment variable check from azure-mcp to mcp
  • Installs platform packages with specific versions instead of @latest for consistency

@hallipr hallipr force-pushed the users/pahallis/non-azure-npm branch from 565e64c to e89095f Compare November 5, 2025 22:57
@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Nov 5, 2025
Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshfree joshfree added this to the 2025-11 milestone Nov 6, 2025
@joshfree joshfree added server-Azure.Mcp Azure.Mcp.Server tools-npx NodeJS Package Manager (NPM, NPX) labels Nov 6, 2025
@hallipr hallipr merged commit 79f576c into main Nov 7, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Nov 7, 2025
@hallipr hallipr deleted the users/pahallis/non-azure-npm branch November 7, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server tools-npx NodeJS Package Manager (NPM, NPX)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants