-
Notifications
You must be signed in to change notification settings - Fork 273
Add more foundry tool tests #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more foundry tool tests #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the AgentsGetSdkCodeSampleCommandTests to use the real FoundryService implementation instead of a mocked service, and adds comprehensive live tests for thread and agent operations in the Foundry command suite.
- Migrated unit test from mocking
IFoundryServiceto using concrete implementation with mocked dependencies - Added live tests for agent creation, thread creation, thread listing, and message retrieval operations
- Introduced
CreateThreadhelper method for test setup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AgentsGetSdkCodeSampleCommandTests.cs | Refactored test setup to use real FoundryService with mocked dependencies instead of mocking the service interface |
| FoundryCommandTests.cs | Added four new live tests and a helper method for thread/agent operations |
tools/Azure.Mcp.Tools.Foundry/tests/Azure.Mcp.Tools.Foundry.LiveTests/FoundryCommandTests.cs
Outdated
Show resolved
Hide resolved
|
LGTM |
What does this PR do?
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline