Skip to content

Conversation

@JasonYeMSFT
Copy link
Member

@JasonYeMSFT JasonYeMSFT commented Nov 5, 2025

What does this PR do?

  • Add live tests for foundry tools
    • agents create
    • threads create
    • threads list
    • threads get-messages
  • Make agents get-sdk-sample unit test to pull the real embedded resources

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copilot AI review requested due to automatic review settings November 5, 2025 22:54
@JasonYeMSFT JasonYeMSFT requested review from a team and xiangyan99 as code owners November 5, 2025 22:54
@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the AgentsGetSdkCodeSampleCommandTests to use the real FoundryService implementation instead of a mocked service, and adds comprehensive live tests for thread and agent operations in the Foundry command suite.

  • Migrated unit test from mocking IFoundryService to using concrete implementation with mocked dependencies
  • Added live tests for agent creation, thread creation, thread listing, and message retrieval operations
  • Introduced CreateThread helper method for test setup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
AgentsGetSdkCodeSampleCommandTests.cs Refactored test setup to use real FoundryService with mocked dependencies instead of mocking the service interface
FoundryCommandTests.cs Added four new live tests and a helper method for thread/agent operations

@joshfree joshfree added server-Azure.Mcp Azure.Mcp.Server tools-Foundry Azure AI Foundry test issue labels Nov 7, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Nov 7, 2025
@joshfree joshfree added this to the 2025-11 milestone Nov 7, 2025
@joshfree
Copy link
Member

joshfree commented Nov 7, 2025

LGTM

@JasonYeMSFT JasonYeMSFT merged commit 6dbd2a9 into microsoft:main Nov 7, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server test issue tools-Foundry Azure AI Foundry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants