Allow loading assemblies without an assembly location #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thhous-msft
requested review from
anramanath,
jmaxson-ms,
mslukebo,
trgibeau and
yesiam0
as code owners
nibanks
reviewed
Nov 30, 2021
Co-authored-by: Nick Banks <nibanks@microsoft.com>
|
This change introduces a large shift in how we think about/interact with plugins, and it's not clear if we want to support loading plugins from executables. I think the current desire is to have plugins be a set of DLLs sitting in some directory. |
|
Our (the MsQuic team) goal here is to have the ability to produce a single EXE binary that can be used to process ETL files, without any additional installation requirements. This change is required to achieve that goal as far as I can tell. |
thhous-msft
changed the title
nibanks
reviewed
Dec 1, 2021
nibanks
approved these changes
Dec 1, 2021
mslukebo
approved these changes
Dec 2, 2021
trgibeau
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177
There are cases where the assembly containing a plugin type might already be loaded. In this case, it would be nice to be able to add the type directly, rather than loaded from a folder. Additionally, there are cases where the plugin assembly might not even exist on disk (This is the case with single file executables). In this case, the type has to be loaded explicitly. There is a way to do this for a single plugin using an IAssemblyLoader, but that fails if the type doesn't have a location. This fixes, so the type can always be loaded.